Skip to content

tools: undefined name opts -> args in gyptest.py#30144

Closed
cclauss wants to merge 1 commit intomasterfrom
opts-to-args
Closed

tools: undefined name opts -> args in gyptest.py#30144
cclauss wants to merge 1 commit intomasterfrom
opts-to-args

Conversation

@cclauss
Copy link
Copy Markdown
Contributor

@cclauss cclauss commented Oct 27, 2019 •
edited
Loading 

./tools/gyp/gyptest.py:61:47: F821 undefined name 'opts'
    extra_path = [os.path.abspath(p) for p in opts.path]
                                              ^

opts.path is an undefined name in this context while args.path is used on the preceding line and is defined on line 48. Undefined names have the potential to raise NameError at runtime which will halt the script.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@richardlau richardlau richardlau approved these changes

@trivikr trivikr trivikr approved these changes

@Trott Trott Awaiting requested review from Trott

@sam-github sam-github Awaiting requested review from sam-github

@bnoordhuis bnoordhuis Awaiting requested review from bnoordhuis

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. python PRs and issues that require attention from people who are familiar with Python. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@cclauss @nodejs-github-bot @lpinca @targos @cjihrig @gengjiawen @richardlau @trivikr